FileCleanup Improvements #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Main Goal
{Describe/list your goal for the PR here}
## PR Status :
- Overall Status : Done/In Progress/Stalled/Cancelled
- Commits : Done/In Progress/Stalled/Cancelled
- Synced to base (Collapse:main) : Yes/Not yet
- Build status : OK/Crashing/Build Errors
- Crashing : Yes/No
- Bug found caused by PR : {int}
### Templates
<details>
<summary>Changelog Prefixes</summary>
```
**[New]**
**[Imp]**
**[Fix]**
**[Loc]**
**[Doc]**
```
</details>
DO NOT ASK HOW LONG THIS TOOK
…lecleanup-improvement
InjectFileSource 1. Increase possible batch size 2. Use Interlock.Increment Delete to Recycle Bin 1. Improve FileInfoSource removal speed
Co-authored-by: Kemal Setya Adhi <[email protected]>
bagusnl
added
Enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| using System.IO; | ||
| using System.Linq; | ||
| using System.Numerics; |
Check warning
Code scanning / QDNET
Redundant using directive Warning
shatyuka
reviewed
Dec 20, 2024
| @@ -220,9 +344,10 @@ private async Task PerformRemoval(ICollection<LocalFileInfo>? deletionSource, lo | |||
| await Task.Run(() => RecycleBin.MoveFileToRecycleBin(toBeDeleted)); | |||
There was a problem hiding this comment.
Should we do it in parallel as well?
There was a problem hiding this comment.
For recycle bin there is no need. It passes the list of files to be deleted to Windows default "Move to recycle bin" method then delete it that way
1. Use backedFileInfoSourceList on InjectFileSource so its faster 2. Remove unnecesary iteration on InjectFileSource 3. Use thread*4 when deleting items
Co-Authored-By: Bagus Nur Listiyono <[email protected]>
+ Initialize deletion file task to fully async with its own thread + Log deletion performance + Pass _assetTotalSize to the injector method instead of the constructor
|
PR finished, merging manually due to submodule merge conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Goal
Improve FileCleanup logics for items > 1000 as before it froze the UI completely
PR Status :